Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualization combined issue #715

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Conversation

Jammy2211
Copy link
Collaborator

Fixes a bug where visualize_combined was called with the wrong inputs by default.

@Jammy2211 Jammy2211 requested a review from rhayes777 June 3, 2023 19:28
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #715 (4369241) into main (cd81ab3) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   82.22%   82.20%   -0.03%     
==========================================
  Files         180      180              
  Lines       13323    13324       +1     
==========================================
- Hits        10955    10953       -2     
- Misses       2368     2371       +3     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

# self,
# analyses: List[af.Analysis],
# paths: af.DirectoryPaths,
# instance: af.ModelInstance,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented code?

@Jammy2211 Jammy2211 merged commit f6ddce4 into main Jun 5, 2023
@Jammy2211 Jammy2211 deleted the feature/visualize_combined branch June 12, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants