Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efivar 39 with efibootmgr 0ca99d4 fails to compile #204

Closed
heitbaum opened this issue Feb 2, 2024 · 3 comments
Closed

efivar 39 with efibootmgr 0ca99d4 fails to compile #204

heitbaum opened this issue Feb 2, 2024 · 3 comments

Comments

@heitbaum
Copy link

heitbaum commented Feb 2, 2024 

UNPACK      efibootmgr
BUILD      efibootmgr (target)
    TOOLCHAIN      make (auto-detect)
make -C src efibootmgr
make[1]: Entering directory '/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/src'
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc   -march=x86-64-v3 -Wall -pipe  -O2 -fomit-frame-pointer -DNDEBUG -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/efivar -fgnu89-inline -Wno-pointer-sign -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/src/include -Werror -Wall -Wextra -Wsign-compare -Wstrict-aliasing -std=gnu11 -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DLOCALEDIR=\"/usr/share/locale/\" -DEFIBOOTMGR_VERSION="\"18\"" -DDEFAULT_LOADER=\"\\\\EFI\\\\BOOT\\\\bootx64.efi\"     -c -o efibootmgr.o efibootmgr.c
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc   -march=x86-64-v3 -Wall -pipe  -O2 -fomit-frame-pointer -DNDEBUG -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/efivar -fgnu89-inline -Wno-pointer-sign -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/src/include -Werror -Wall -Wextra -Wsign-compare -Wstrict-aliasing -std=gnu11 -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DLOCALEDIR=\"/usr/share/locale/\" -DEFIBOOTMGR_VERSION="\"18\"" -DDEFAULT_LOADER=\"\\\\EFI\\\\BOOT\\\\bootx64.efi\"     -c -o efi.o efi.c
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc   -march=x86-64-v3 -Wall -pipe  -O2 -fomit-frame-pointer -DNDEBUG -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/efivar -fgnu89-inline -Wno-pointer-sign -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/src/include -Werror -Wall -Wextra -Wsign-compare -Wstrict-aliasing -std=gnu11 -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DLOCALEDIR=\"/usr/share/locale/\" -DEFIBOOTMGR_VERSION="\"18\"" -DDEFAULT_LOADER=\"\\\\EFI\\\\BOOT\\\\bootx64.efi\"     -c -o parse_loader_data.o parse_loader_data.c
efi.c: In function 'make_linux_load_option':
efi.c:177:26: error: implicit declaration of function 'efi_generate_ipv4_device_path_with_uri'; did you mean 'efi_generate_ipv4_device_path'? [-Werror=implicit-function-declaration]
  177 |                 needed = efi_generate_ipv4_device_path_with_uri(
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                          efi_generate_ipv4_device_path
cc1: all warnings being treated as errors
make[1]: *** [/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/Make.rules:32: efi.o] Error 1
make[1]: Leaving directory '/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/src'
make: *** [Makefile:25: efibootmgr] Error 2
@heitbaum heitbaum mentioned this issue Feb 2, 2024
Closed
@heitbaum
Copy link
Author

heitbaum commented Feb 2, 2024

@lupoDharkael
Copy link

The CI also seems to be failing since that commit, I had to revert that commit in order to compile against efivar-39.

pvxe added a commit to pvxe/efibootmgr-json that referenced this issue Feb 27, 2024
@pvxe
Revert "Implement --uri option for use with --ifname"
e22a7d7 
This reverts commit 5ce076c.

This commit uses functionality which is not present in efivar-39.
See rhboot#204.
@pvxe pvxe mentioned this issue Feb 27, 2024
Open
@heitbaum
Copy link
Author

The commit has now been reverted e616023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heitbaum @lupoDharkael