Fix load option regression #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9e8dde5. A fix for the actual NULL pointer, to turn `cur = li->LoadOptions` into `cur = start = li->LoadOptions` is in the next patch. Bug-Ubuntu: https://bugs.launchpad.net/bugs/1929471
This variable was not initialized, but the fix in 9e8dde5 was wrong, so after reverting it, just initialize the variable like in the `if` path above it. An alternative is to check for `start == NULL` inside the if below this, instead of, or in addition to `start == li->LoadOptions`.
|
Hmm, this actually did not fix fwupd either. So I guess, no fwupd fix for now, and I'll submit a broken shim for now and submit another one with #379 later. So frustrating. |
This was referenced Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #374 and #379 that just reverts the flawed commit and then initializes the start variable as it does in the previous code path in
if