Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback: fix fallback not passing arguments of the first boot option #433

Merged
merged 1 commit into from
Dec 10, 2021

Commits on Nov 9, 2021

  1. fallback: fix fallback not passing arguments of the first boot option

    The buffer used to read the data in the CSV is declared as a stack variable
    in the try_boot_csv() function, but a pointer to the arguments field of the
    first boot option is stored in the global first_new_option_args variable.
    
    Later, when is used set the arguments to boot the first entry, the variable
    points to memory that no longer exists. This leads to booting an entry with
    garbage as arguments instead of the correct value.
    
    Reported-by: Alexander Larsson <alexl@redhat.com>
    Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
    martinezjavier committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    6504007 View commit details
    Browse the repository at this point in the history