shim: use SHIM_DEVEL_VERBOSE when built in devel mode #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozencemetery
approved these changes
May 13, 2022
lib/console.c
Outdated
| @@ -699,9 +699,15 @@ setup_verbosity(VOID) | |||
| EFI_STATUS efi_status; | |||
| UINT8 *verbose_check_ptr = NULL; | |||
| UINTN verbose_check_size; | |||
| const CHAR16 * const verbose_var_name = | |||
| #ifdef ENABLE_SHIM_DEVEL | |||
There was a problem hiding this comment.
I would personally do this as a #define rather than littering the variable initialization with ifdefs, but it's not wrong or anything.
This makes SHIM_VERBOSE / SHIM_DEVEL_VERBOSE work the same way as SHIM_DEBUG / SHIM_DEVEL_DEBUG when shim is built with ENABLE_SHIM_DEVEL set. Signed-off-by: Peter Jones <pjones@redhat.com>
vathpela
force-pushed
the
more-shim-devel-variable
branch
from
d356364
to
bba321f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes SHIM_VERBOSE / SHIM_DEVEL_VERBOSE work the same way as
SHIM_DEBUG / SHIM_DEVEL_DEBUG when shim is built with ENABLE_SHIM_DEVEL
set.
Signed-off-by: Peter Jones pjones@redhat.com