SBAT Policy latest should be a one-shot #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since booting from removable media can be hard to detect, setting a persistent latest SBAT policy is risky in a typical client system. This changes latest to be a one-shot operation that could be set at the time of an OS update if desired. Signed-off-by: Jan Setje-Eilers <Jan.SetjeEilers@oracle.com>
vathpela
requested changes
May 24, 2022
| break; | ||
| case SBAT_POLICY_PREVIOUS: | ||
| dprint("Custom sbat policy: previous\n"); | ||
| sbat_var = SBAT_VAR_PREVIOUS; | ||
| break; | ||
| case SBAT_POLICY_RESET: | ||
| if (secure_mode()) { | ||
| console_print(L"Cannot reset SBAT policy: Secure Boot is enabled.\n"); | ||
| console_print(L"Cannot reset SBAT policy: " |
There was a problem hiding this comment.
Don't break strings across lines for formatting, leave them intact so they're easy to grep for.
|
I've pushed the fix as 77144e5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since booting from removable media can be hard to detect,
setting a persistent latest SBAT policy is risky in a typical
client system. This changes latest to be a one-shot operation
that could be set at the time of an OS update if desired.