Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shim: Allow data after the end of device path node in load options #694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Oct 2, 2024

  1. shim: Allow data after the end of device path node in load options

    When looking for load option optional data, the parser asserts that the
    byte after the end of device path node is the same as what the file path
    length says it should be. While unusual, it is valid if the end of
    device path node comes before the end of the file path list.
    
    That supports some unusual Dell load options where there are two device
    paths in the list but the first is terminated by an End Entire Device
    Path. Maybe they intended to use an End Device Path Instance node there?
    Who knows. Either way, treating it as invalid ends up trying to read
    paths from the beginning of the option with obviously poor results.
    
    Fixes: rhboot#649
    
    Signed-off-by: Dan Nicholson <dbn@endlessos.org>
    dbnicholson committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2cabe53 View commit details
    Browse the repository at this point in the history