This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
Issue-38: Add functions to generate Tekton task objects #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added functions and test cases to create 1) deploy-from-source-task 2) deploy-using-kubectl-task 3) github-status-task Co-Authored-By: Gagan Hegde <ghegde@redhat.com>
bigkevmcd
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
Looks good, some minor changes (the stuttering should be fixed, the shortening of tests is discretionary).
Ooops, and the v1alpha1 vs v1alpha2, we agreed that we'd hold use of v1alpha2 until tektoncd/pipeline#2035 lands.
- Removed stuttering function names in tasks,routes and eventlisteners package. - Objects in task_tests are replaced by functions to improve readability.
wtam2018
reviewed
Feb 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does does this PR do / why we need it:
Added functions and test cases to create
Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/projects/GITOPS/issues/GITOPS-38