Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sprites-Miscroutines #5

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update Sprites-Miscroutines #5

wants to merge 8 commits into from

Conversation

XBloonyX
Copy link
Contributor

No description provided.

@XBloonyX
Copy link
Contributor Author

Hey buddy, how are you going with the sprite review?

@XBloonyX
Copy link
Contributor Author

before you finish, I updated the interaction with Sprite11: Buzzy Bettle and Sprite0F: Goomba so you know before finishing ... thanks for your patience :)

rhelmot
rhelmot requested changes Jan 4, 2019
View reviewed changes
Copy link
Owner

@rhelmot rhelmot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all the issues I could find just based on looking at the code. Could you post a list of sprites you changed so I can put them all in a level and just test them by playing the game?

src/miscroutines.asm Outdated
@@ -35,7 +35,7 @@ TXA
CLC
ADC #$0C
TAX
JSR UpdatePosY
JSR UpdatePosY
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generally considered poor form to have lines ending with whitespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is ending with a blank space, it's not my fault, it's that the editor who uses

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is ending with a blank space, it's not my fault, it's that the editor who uses

src/miscroutines.asm
@@ -145,15 +145,12 @@ BNE .end
LDA $0DB9
AND #$18
if !THREEPLAYER || !!SMALLPLAYERS
CMP #$08
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incorrect change - the line you've changed is surrounded by if !THREEPLAYER || !!SMALLPLAYERS, which means that it will only be included in the patch if either the THREEPLAYER option is set or the SMALLPLAYERS option is unset. It means that luigi will be killed when his powerup status is big luigi, which is the intended behavior for those modes.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THREEPLAYER is a mode where there are three different player sprites, of which the two you play as are different depending on the safe file you're using. It's used for the my little pony sprites. There isn't enough graphics space for both big and small characters in this mode, so the "small mario" state is disabled while it's on.

SMALLPLAYERS enables the "small mario" state. When it's off, players will start as the big powerup and die when hit in that mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do not know how that happened if I do not touch anything in the 3-player code :/

(Maybe that's why that mode did not work properly when I tried it :V)

and if it's almost everything you just told me, obviously I have to know the basics of the patch but thanks for the information

src/miscroutines.asm
STA $1504,x
LDA #$2F
STA $151C,x
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disables the shrinking animation when luigi gets hit. Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that that eliminates it ... but it is very uncomfortable while you are on a level with platforms that move in a straight line (room 00F) and jump to grab a mushroom, since the screen does not freeze, luigi is in the air and the platform leaves it behind letting it fall into a precipice, the animation would be much better if the screen freezes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and when you're hit it's also the same case

src/miscroutines.asm
@@ -180,7 +177,7 @@ LDA #$E8
STA $B6,x
endif

LDA #$60
LDA #$90
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the correct value is actually 7F (see $00D140 in the smw rom)

src/miscroutines.asm Outdated
;
; SuperBoostSpeed
;
; SuperBoost's Luigi's speed as though he stomped on an enemy.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify the difference between a boost and a superboost?

src/sprites.asm Outdated
LDX $0F65
RTS

JumpNoSquash:;JUMP NO MATANDO SPRITES
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments should be in english :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im fixing that :(

src/sprites.asm Outdated
@@ -777,60 +922,321 @@ RTS
.koopanumbers
db $04,$04,$05,$05,$07

Sprite0D: ;keyhole
Sprite0D:;Bob-omb
JSR Sprite0F
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a call to Sprite0F, you should move the Sprite0D label to the same position as Sprite0F. Look at how Sprite08-Sprite0C do it immediately above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that I'm also fixing it ... it's just that I did not know about the sprites

src/sprites.asm
LDA $14C8,y
CMP #$09
BNE GoombaReg
akakakakaka:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

labels should generally be descriptive...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, this code is a copy of the interaction of the koopa (changed to work)

src/sprites.asm Outdated
LDA $14C8,y
CMP #$09
BNE BuzzyReg
akakakaka:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as above

src/sprites.asm Outdated
RTS

Sprite2A: ;upside down piranah plant
Sprite2D:;Baby Green Yoshi
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no point in supporting the baby yoshi since it's impossible to support adult yoshi. There just isn't enough space in SP1 VRAM for both luigi and yoshi.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but I could not leave it as it was :v

@XBloonyX
Copy link
Contributor Author

ok thanks for reporting the errors, leave me and I try to fix it as fast as possible :(

XBloonyX added 3 commits June 7, 2019 09:05
@XBloonyX
Update sprites.asm
c0c1e0f 
(need my misc routnies to work) 
Added a Large Number of interactions :D
@XBloonyX
Update miscroutines.asm
00b5fab
@XBloonyX
Merge pull request #3 from XBloonyX/XBloonyX-sprites-Remastered!
ccf3f34 
Update sprites.asm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhelmot rhelmot rhelmot requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XBloonyX @rhelmot