Merge pull request flutter#19 from dart-lang/make-FailingTest-public

Make FailingTest public.
rhencke · Jul 20, 2018 · 0a760d0 · 0a760d0
2 parents 4033df1 + cdedf60
commit 0a760d0
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.1.6
+
+- Make `FailingTest` public, with the URI of the issue that causes
+  the test to break.
+
 ## 0.1.5
 
 - Set max SDK version to `<3.0.0`, and adjust other dependencies.

diff --git a/lib/test_reflective_loader.dart b/lib/test_reflective_loader.dart
@@ -21,7 +21,7 @@ const _AssertFailingTest assertFailingTest = const _AssertFailingTest();
  * A marker annotation used to annotate overridden test methods (so we cannot
  * rename them to `fail_`) which are expected to fail.
  */
-const _FailingTest failingTest = const _FailingTest();
+const FailingTest failingTest = const FailingTest(null);
 
 /**
  * A marker annotation used to instruct dart2js to keep reflection information
@@ -267,11 +267,11 @@ Future _runTest(ClassMirror classMirror, Symbol symbol) {
 typedef dynamic _TestFunction();
 
 /**
- * A marker annotation used to instruct dart2js to keep reflection information
- * for the annotated classes.
+ * A marker annotation used to annotate overridden test methods (so we cannot
+ * rename them to `fail_`) which are expected to fail.
  */
-class _ReflectiveTest {
-  const _ReflectiveTest();
+class FailingTest {
+  const FailingTest(String issueUri);
 }
 
 /**
@@ -293,14 +293,6 @@ class _AssertFailingTest {
   const _AssertFailingTest();
 }
 
-/**
- * A marker annotation used to annotate overridden test methods (so we cannot
- * rename them to `fail_`) which are expected to fail.
- */
-class _FailingTest {
-  const _FailingTest();
-}
-
 /**
  * Information about a type based test group.
  */
@@ -321,6 +313,14 @@ class _Group {
   }
 }
 
+/**
+ * A marker annotation used to instruct dart2js to keep reflection information
+ * for the annotated classes.
+ */
+class _ReflectiveTest {
+  const _ReflectiveTest();
+}
+
 /**
  * A marker annotation used to annotate "solo" groups and tests.
  */

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: test_reflective_loader
-version: 0.1.5
+version: 0.1.6
 
 description: Support for discovering tests and test suites using reflection.
 author: Dart Team <misc@dartlang.org>