Skip to content

Commit

Permalink
Stop depending on stack_trace (flutter#123)
Browse files Browse the repository at this point in the history
At this point, we're only using this for Chain.current which might as
well just be StackTrace.current.

This is a cherry-pick of 77d470ac45a4c8972fe5ad4e58170dc0607240a0 into
the 0.11.x branch.

Closes flutter#122
  • Loading branch information
nex3 authored Oct 13, 2017
1 parent 3b551fb commit 332d6cf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.11.3+16

* Stop depending on the `stack_trace` package.

## 0.11.3+15

* Declare support for `async` 2.0.0.
Expand Down
6 changes: 2 additions & 4 deletions lib/browser_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import 'dart:async';
import 'dart:html';
import 'dart:typed_data';

import 'package:stack_trace/stack_trace.dart';

import 'src/base_client.dart';
import 'src/base_request.dart';
import 'src/byte_stream.dart';
Expand Down Expand Up @@ -71,7 +69,7 @@ class BrowserClient extends BaseClient {
reader.onError.first.then((error) {
completer.completeError(
new ClientException(error.toString(), request.url),
new Chain.current());
StackTrace.current);
});

reader.readAsArrayBuffer(blob);
Expand All @@ -82,7 +80,7 @@ class BrowserClient extends BaseClient {
// specific information about the error itself.
completer.completeError(
new ClientException("XMLHttpRequest error.", request.url),
new Chain.current());
StackTrace.current);
});

xhr.send(bytes);
Expand Down
3 changes: 1 addition & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: http
version: 0.11.3+15
version: 0.11.3+16
author: "Dart Team <misc@dartlang.org>"
homepage: https://github.com/dart-lang/http
description: A composable, Future-based API for making HTTP requests.
Expand All @@ -8,7 +8,6 @@ dependencies:
collection: "^1.5.0"
http_parser: ">=0.0.1 <4.0.0"
path: ">=0.9.0 <2.0.0"
stack_trace: ">=0.9.1 <2.0.0"
dev_dependencies:
unittest: ">=0.9.0 <0.12.0"
environment:
Expand Down

0 comments on commit 332d6cf

Please sign in to comment.