Skip to content

Commit

Permalink
Remove upper case constants (flutter#17)
Browse files Browse the repository at this point in the history
* Remove usage of upper-case constants.

* update SDK version
* Remove 1.23.0 from travis config.
  • Loading branch information
lrhn authored May 23, 2018
1 parent e05e194 commit 4d3580a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ language: dart

dart:
- dev
- stable
- 1.23.0

dart_task:
- test: --platform vm
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## 3.1.2

* Require Dart SDK 1.23 or greater.
* Require Dart SDK 2.0.0-dev.17.0 or greater.

* A number of strong-mode fixes.

Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ homepage: https://github.com/dart-lang/http_parser
description: >
A platform-independent package for parsing and serializing HTTP formats.
environment:
sdk: ">=1.23.0 <2.0.0"
sdk: ">=2.0.0-dev.17.0 <2.0.0"
dependencies:
charcode: "^1.1.0"
collection: ">=0.9.1 <2.0.0"
Expand Down
8 changes: 4 additions & 4 deletions test/http_date_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void main() {
test("parses the example date", () {
var date = parseHttpDate("Sun, 06 Nov 1994 08:49:37 GMT");
expect(date.day, equals(6));
expect(date.month, equals(DateTime.NOVEMBER));
expect(date.month, equals(DateTime.november));
expect(date.year, equals(1994));
expect(date.hour, equals(8));
expect(date.minute, equals(49));
Expand Down Expand Up @@ -147,7 +147,7 @@ void main() {
test("parses the example date", () {
var date = parseHttpDate("Sunday, 06-Nov-94 08:49:37 GMT");
expect(date.day, equals(6));
expect(date.month, equals(DateTime.NOVEMBER));
expect(date.month, equals(DateTime.november));
expect(date.year, equals(1994));
expect(date.hour, equals(8));
expect(date.minute, equals(49));
Expand Down Expand Up @@ -239,7 +239,7 @@ void main() {
test("parses the example date", () {
var date = parseHttpDate("Sun Nov 6 08:49:37 1994");
expect(date.day, equals(6));
expect(date.month, equals(DateTime.NOVEMBER));
expect(date.month, equals(DateTime.november));
expect(date.year, equals(1994));
expect(date.hour, equals(8));
expect(date.minute, equals(49));
Expand All @@ -250,7 +250,7 @@ void main() {
test("parses a date with a two-digit day", () {
var date = parseHttpDate("Sun Nov 16 08:49:37 1994");
expect(date.day, equals(16));
expect(date.month, equals(DateTime.NOVEMBER));
expect(date.month, equals(DateTime.november));
expect(date.year, equals(1994));
expect(date.hour, equals(8));
expect(date.minute, equals(49));
Expand Down

0 comments on commit 4d3580a

Please sign in to comment.