Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fill_func to fillna #1 #18

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

ghk829
Copy link

@ghk829 ghk829 commented May 22, 2019

What does this PR do?

I add the parameters a fill_func for filling NA

default is the same as the original
and
we can expand the function to fill the NAs

Where should the reviewer start?

the constructer of the autoclean function

How should this PR be tested?

I add the test function in tests.py

Any background context you want to provide?

python dynamically import and numpy nanfunctions modules

What are the relevant issues?

#1

Screenshots (if appropriate)

Questions:

  • Do the docs need to be updated?
    If my pull request is admitted, I will add docs
  • Does this PR add new (Python) dependencies?
    Nope

@ghk829
Copy link
Author

ghk829 commented May 22, 2019

Travis Ci build failed for the reasons.
Can I fix the issues?

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 80.377% when pulling 69aeb92 on ghk829:development into f6f92d7 on rhiever:development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants