Skip to content

Commit

Permalink
Merge pull request #423 from rhinogram/RHIN-11665-hover
Browse files Browse the repository at this point in the history
adds title option to Select component to allow hover text
  • Loading branch information
marymhart authored Feb 7, 2025
2 parents a12dc31 + f55f322 commit fafe852
Show file tree
Hide file tree
Showing 15 changed files with 131 additions and 129 deletions.
2 changes: 1 addition & 1 deletion dist/animation/flag/sprite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dist/animation/login/sprite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dist/animation/secure/sprite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dist/animation/time/sprite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dist/css/rhinostyle.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/scripts/rhinostyle.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/scripts/rhinostyle.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/animation/flag/sprite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/animation/login/sprite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/animation/secure/sprite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/animation/time/sprite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/css/rhinostyle-docs.css.map

Large diffs are not rendered by default.

232 changes: 116 additions & 116 deletions docs/scripts/rhinostyle-docs.js

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/scripts/components/Select.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ class Select extends React.Component {
value={this.props.selected}
onChange={this.onChange}
data-cypress={this.props.dataCypress}
title={this.props.title || label}
>
{options.map(renderOpts)}
</select>
Expand Down Expand Up @@ -248,6 +249,7 @@ Select.propTypes = {
validationMessage: PropTypes.string,
placeholder: PropTypes.string,
dataCypress: PropTypes.string,
title: PropTypes.string,
};

Select.defaultProps = {
Expand Down
2 changes: 1 addition & 1 deletion src/scripts/docs/examples/Select.example.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class ComponentExample extends React.Component {

render() {
return (
<Select placeholder="Select an option" onSelect={this.handleSelect} selected={this.state.selected} name="mySelect" label="Choose One" options={this.selectOpts} />
<Select placeholder="Select an option" onSelect={this.handleSelect} selected={this.state.selected} name="mySelect" label="Choose One" options={this.selectOpts} title="hover text"/>
);
}
}

0 comments on commit fafe852

Please sign in to comment.