Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Anaconda daily COPR builds to Packit #3036

Conversation

jkonecny12
Copy link
Member

Packit should handle this for us.

Unfortunately, I don't know how to test this. So I guess we have to tune it here in the repository directly? I'll try to figure out something with my fork.

@jkonecny12 jkonecny12 added the master Please, use the `f39` label instead. label Dec 3, 2020
@jkonecny12 jkonecny12 force-pushed the master-migrate-daily-builds-to-packit branch from fda0db0 to c169ba4 Compare December 3, 2020 15:25
@rhinstaller rhinstaller deleted a comment from packit-as-a-service bot Dec 3, 2020
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

⚠️ Please note that our current plans include removal of these comments in the near future (at least 2 weeks after including this disclaimer), if you have serious concerns regarding their removal or would like to continue receiving them please reach out to us. ⚠️

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/rhinstaller-anaconda-3036
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's a bit difficult to test indeed. But the values match our COPR, so let's try this and see how it works. Thanks!

@jkonecny12 jkonecny12 force-pushed the master-migrate-daily-builds-to-packit branch from c169ba4 to c68ba5f Compare December 3, 2020 17:33
@jkonecny12
Copy link
Member Author

jkonecny12 commented Dec 3, 2020

I was able to test it on my fork, it wasn't that hard at the end.

You can see the results here:
jkonecny12@21dd0e7

Unfortunately, blivet does not support daily builds of ELN right now so it won't work with one configuration. @vojtechtrefny do you have ELN daily builds somewhere else or do you want me to add you a packit support for "commit" builds like we have here?

Another solution is to use blivet from ELN repository. Which may be even more correct solution. However, on that I guess we need a new copr repository so maybe it's not worth the effort. Not sure if we even need ELN daily builds.

@vojtechtrefny
Copy link
Contributor

Unfortunately, blivet does not support daily builds of ELN right now so it won't work with one configuration. @vojtechtrefny do you have ELN daily builds somewhere else

I've enabled ELN builds in our repo. Lets hope it will be more stable than last time I tried.

or do you want me to add you a packit support for "commit" builds like we have here?

Is packit stable enough now? Builds on our PRs fail very often, I'm not sure if I want something like that for our daily builds too. Our existing solution works and that's good enough for now. Maybe someday when TODO list is emptier, I'll give a try.

@jkonecny12
Copy link
Member Author

Unfortunately, blivet does not support daily builds of ELN right now so it won't work with one configuration. @vojtechtrefny do you have ELN daily builds somewhere else

I've enabled ELN builds in our repo. Lets hope it will be more stable than last time I tried.

or do you want me to add you a packit support for "commit" builds like we have here?

Is packit stable enough now? Builds on our PRs fail very often, I'm not sure if I want something like that for our daily builds too. Our existing solution works and that's good enough for now. Maybe someday when TODO list is emptier, I'll give a try.

Packit is pretty stable. What is failing is Testing Farm Cluster which should be migrated in January (last info). However, this is required only for running tests so if you are doing releases or COPR builds than it's pretty stable just some flakes from time to time but not really that problematic.

Lets use Packit for this work.
@jkonecny12 jkonecny12 force-pushed the master-migrate-daily-builds-to-packit branch from c68ba5f to 42233eb Compare December 4, 2020 10:32
@jkonecny12
Copy link
Member Author

UPDATED:

Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@jkonecny12 jkonecny12 merged commit 4e4f094 into rhinstaller:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
Development

Successfully merging this pull request may close these issues.

6 participants