Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iscsi: Allow changing iSCSI initiator name once set #4933

Conversation

vojtechtrefny
Copy link
Contributor

Blivet (and UDisks) now allow changing of the initiator name which can now be changed unless an active session already exists.

Resolves: rhbz#2223980

Blivet changes: storaged-project/blivet#1146

Blivet (and UDisks) now allow changing of the initiator name which
can now be changed unless an active session already exists.

Resolves: rhbz#2223980
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@VladimirSlavik
Copy link
Contributor

/kickstart-test --testtype smoke

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkonecny12 jkonecny12 added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Aug 9, 2023
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkonecny12 jkonecny12 merged commit 2cb5635 into rhinstaller:rhel-8 Aug 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel8-branch
Development

Successfully merging this pull request may close these issues.

4 participants