Implement support for running on Wayland through Weston #5401

Conan-Kudo · 2024-01-15T02:02:22Z

This implements rudimentary support for running Anaconda on Wayland using the Weston compositor through XWayland. This support also includes simple auth-less VNC remote access, though authenticated VNC support requires extra effort since Weston's authenticated VNC support uses TLS certificates and we do not have a good way to plumb that through right now (more info in weston-vnc(7)).

pep8speaks · 2024-01-15T02:02:31Z

Hello @Conan-Kudo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pyanaconda/display_wayland.py:

Line 146:100: E501 line too long (107 > 99 characters)
Line 289:100: E501 line too long (104 > 99 characters)
Line 311:100: E501 line too long (115 > 99 characters)
Line 312:100: E501 line too long (110 > 99 characters)
Line 313:100: E501 line too long (107 > 99 characters)

In the file pyanaconda/display_x11.py:

Line 147:100: E501 line too long (107 > 99 characters)
Line 378:100: E501 line too long (115 > 99 characters)
Line 379:100: E501 line too long (103 > 99 characters)
Line 380:100: E501 line too long (107 > 99 characters)

Comment last updated at 2024-01-20 00:43:20 UTC

VladimirSlavik

Without understanding the problem domain, LGTM so far.

VladimirSlavik · 2024-01-17T12:36:35Z

pyanaconda/core/util.py

+    argv = ["weston", f"--config={weston_config_file}", "--log=/tmp/weston.log",
+            f"--socket={WAYLAND_SOCKET_NAME}"]


We aren't using f-strings anywhere else. Not sure if it means they can't be used at all, though.

f-strings were added in Python 3.6. I think it's pretty reasonable to state that we're probably not going to be running this Anaconda codebase on something older than that, since Python 3.6 is what RHEL 8 shipped with. I can certainly change it, but I liked how it make this easier to read.

Sure, it would be possible to use f-strings on the platforms we care about, it has been more a question of team policy or consistency so far not to use them in the Anaconda code.

VladimirSlavik · 2024-01-17T12:37:35Z

pyanaconda/core/util.py

+            sock.close()
+            wl_status.started = True
+            return wl_status.started
+        except Exception:


Can this be more specific than just Exception?

In theory, I could, but I have intentionally not done so because I want it to happen in any exception case. It's merely for shorting the loop to iterate on the timeout.

Conan-Kudo · 2024-01-17T14:06:11Z

@VladimirSlavik, @jkonecny12, @M4rtinK: do any of you know what I'm doing wrong with the Autotools definition to add the PAM file? I'm not sure how to fix it...

Conan-Kudo · 2024-01-17T15:09:00Z

Ah, I figured it out now, and it looks like the package builds are going now.

M4rtinK · 2024-01-17T15:21:49Z

/build-image --boot.iso

github-actions · 2024-01-17T15:30:46Z

Images built based on commit c09c693:

boot.iso: failure

Download the images from the bottom of the job status page.

M4rtinK · 2024-01-17T15:41:41Z

/build-image --boot.iso

github-actions · 2024-01-17T15:50:54Z

Images built based on commit 9f70bee:

boot.iso: failure

Download the images from the bottom of the job status page.

KKoukiou

@Conan-Kudo Kudos on the awesome job, this contribution is in great state and I see it already uncovered some issues (Lorax templates)! 🌟

However, I've got a few thoughts about merging that I wanted to share.

Our team's got some recent "capacity challenges" post you might wanna check out: Check the post here. It paints a bit of the picture we're dealing with right now.

Here's the thing – about Weston, there's some uncertainty on downstream support (probably not at all), and keeping this as an upstream only change, means we are without the QE team on board, so this could create a headache for us maintenance-wise. Plus, we're in the trenches porting Anaconda to XWayland already, so probably there is some conflicting areas in your work with what @M4rtinK is currently working on.

I'm thinking it might be wise to keep this open and not merge it for now, aligning it with our current WIP changes towards xwayland but without introducing Fedora only solutions (Weston).

Conan-Kudo · 2024-01-17T19:01:59Z

@KKoukiou In general, I think what I'm working on and what @M4rtinK is working on will not conflict. Changing Anaconda's behaviors as an XWayland application is complementary to this. All this does is make it so that we run Anaconda as an XWayland application and wires up both the default and VNC modes to Weston as a Wayland compositor.

There are separate work items that need to be done to further improve the experience, and @M4rtinK's work is positioned to help here.

Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <neal@gompa.dev> Co-authored-by: Martin Kolman <mkolman@redhat.com> Co-authored-by: Ray Strode <rstrode@redhat.com>

Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Resolves: https://issues.redhat.com/browse/RHEL-38399 Co-authored-by: Neal Gompa <neal@gompa.dev> Co-authored-by: Martin Kolman <mkolman@redhat.com> Co-authored-by: Ray Strode <rstrode@redhat.com>

Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <neal@gompa.dev> Co-authored-by: Martin Kolman <mkolman@redhat.com> Co-authored-by: Ray Strode <rstrode@redhat.com> Resolves: RHEL-38399

github-actions · 2024-06-30T02:24:54Z

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

Conan-Kudo · 2024-06-30T04:25:23Z

This will be rebased once #5498 is merged in the main branch.

Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <neal@gompa.dev> Co-authored-by: Martin Kolman <mkolman@redhat.com> Co-authored-by: Ray Strode <rstrode@redhat.com> Resolves: RHEL-38399 (cherry picked from commit 8800331)

Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <neal@gompa.dev> Co-authored-by: Martin Kolman <mkolman@redhat.com> Co-authored-by: Ray Strode <rstrode@redhat.com> Resolves: RHEL-38399 Resolves: https://fedoraproject.org/wiki/Changes/AnacondaWebUIforFedoraWorkstation (cherry picked from commit 8800331)

github-actions · 2024-08-30T02:30:29Z

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

Conan-Kudo · 2024-08-30T02:31:47Z

Waiting for #5829 to land before rebasing.

Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <neal@gompa.dev> Co-authored-by: Martin Kolman <mkolman@redhat.com> Co-authored-by: Ray Strode <rstrode@redhat.com> Resolves: RHEL-38399 Resolves: https://fedoraproject.org/wiki/Changes/AnacondaWebUIforFedoraWorkstation (cherry picked from commit 8800331)

github-actions · 2024-11-05T02:35:21Z

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

Conan-Kudo · 2024-11-14T12:50:37Z

Now that everything has landed in the master branch, I can look at rebasing this...

Conan-Kudo had a problem deploying to gh-cockpituous January 15, 2024 02:02 — with GitHub Actions Failure

github-actions bot added the f40 label Jan 15, 2024

Conan-Kudo force-pushed the waylandize branch from 162372f to 6abac9b Compare January 15, 2024 02:03

Conan-Kudo had a problem deploying to gh-cockpituous January 15, 2024 02:04 — with GitHub Actions Failure

Conan-Kudo force-pushed the waylandize branch from 6abac9b to cd6f7ab Compare January 15, 2024 02:08

Conan-Kudo had a problem deploying to gh-cockpituous January 15, 2024 02:08 — with GitHub Actions Failure

Conan-Kudo force-pushed the waylandize branch from cd6f7ab to ed4288c Compare January 15, 2024 02:52

Conan-Kudo had a problem deploying to gh-cockpituous January 15, 2024 02:52 — with GitHub Actions Failure

VladimirSlavik reviewed Jan 17, 2024

View reviewed changes

Conan-Kudo force-pushed the waylandize branch from ed4288c to ea21578 Compare January 17, 2024 14:00

Conan-Kudo had a problem deploying to gh-cockpituous January 17, 2024 14:00 — with GitHub Actions Failure

Conan-Kudo force-pushed the waylandize branch from ea21578 to 2fb6f80 Compare January 17, 2024 15:05

Conan-Kudo had a problem deploying to gh-cockpituous January 17, 2024 15:05 — with GitHub Actions Failure

Conan-Kudo force-pushed the waylandize branch from 2fb6f80 to c09c693 Compare January 17, 2024 15:19

Conan-Kudo had a problem deploying to gh-cockpituous January 17, 2024 15:19 — with GitHub Actions Failure

Conan-Kudo force-pushed the waylandize branch from c09c693 to 9f70bee Compare January 17, 2024 15:27

Conan-Kudo had a problem deploying to gh-cockpituous January 17, 2024 15:27 — with GitHub Actions Failure

This was referenced Jan 17, 2024

templates.d/99-generic/runtime-cleanup: Do not purge sound packages weldr/lorax#1364

Closed

templates.d/99-generic/runtime-cleanup: Purge more sound binaries weldr/lorax#1365

Closed

KKoukiou reviewed Jan 17, 2024

View reviewed changes

Conan-Kudo force-pushed the waylandize branch from 9f70bee to 70b8821 Compare January 17, 2024 18:53

Conan-Kudo had a problem deploying to gh-cockpituous January 17, 2024 18:53 — with GitHub Actions Failure

github-actions bot added the stale label Jun 30, 2024

github-actions bot removed the stale label Jul 1, 2024

github-actions bot added the stale label Aug 30, 2024

github-actions bot removed the stale label Aug 31, 2024

jkonecny12 added f42 Fedora 42 and removed f41 labels Sep 5, 2024

KKoukiou mentioned this pull request Oct 29, 2024

DONT MERGE: Prefer https://github.com/rhinstaller/anaconda/pull/5401/ #5969

Closed

KKoukiou temporarily deployed to gh-cockpituous October 29, 2024 07:09 — with GitHub Actions Inactive

github-actions bot added the stale label Nov 5, 2024

github-actions bot removed the stale label Nov 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement support for running on Wayland through Weston #5401

Implement support for running on Wayland through Weston #5401

Conan-Kudo commented Jan 15, 2024

pep8speaks commented Jan 15, 2024 •

edited

Loading

VladimirSlavik left a comment

VladimirSlavik Jan 17, 2024 •

edited

Loading

Conan-Kudo Jan 17, 2024

M4rtinK Jan 17, 2024

VladimirSlavik Jan 17, 2024

Conan-Kudo Jan 17, 2024

Conan-Kudo commented Jan 17, 2024

Conan-Kudo commented Jan 17, 2024

M4rtinK commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

M4rtinK commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

KKoukiou left a comment

Conan-Kudo commented Jan 17, 2024

github-actions bot commented Jun 30, 2024

Conan-Kudo commented Jun 30, 2024

github-actions bot commented Aug 30, 2024

Conan-Kudo commented Aug 30, 2024

github-actions bot commented Nov 5, 2024

Conan-Kudo commented Nov 14, 2024

		argv = ["weston", f"--config={weston_config_file}", "--log=/tmp/weston.log",
		f"--socket={WAYLAND_SOCKET_NAME}"]

Implement support for running on Wayland through Weston #5401

Are you sure you want to change the base?

Implement support for running on Wayland through Weston #5401

Conversation

Conan-Kudo commented Jan 15, 2024

pep8speaks commented Jan 15, 2024 • edited Loading

Comment last updated at 2024-01-20 00:43:20 UTC

VladimirSlavik left a comment

Choose a reason for hiding this comment

VladimirSlavik Jan 17, 2024 • edited Loading

Choose a reason for hiding this comment

Conan-Kudo Jan 17, 2024

Choose a reason for hiding this comment

M4rtinK Jan 17, 2024

Choose a reason for hiding this comment

VladimirSlavik Jan 17, 2024

Choose a reason for hiding this comment

Conan-Kudo Jan 17, 2024

Choose a reason for hiding this comment

Conan-Kudo commented Jan 17, 2024

Conan-Kudo commented Jan 17, 2024

M4rtinK commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

M4rtinK commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

KKoukiou left a comment

Choose a reason for hiding this comment

Conan-Kudo commented Jan 17, 2024

github-actions bot commented Jun 30, 2024

Conan-Kudo commented Jun 30, 2024

github-actions bot commented Aug 30, 2024

Conan-Kudo commented Aug 30, 2024

github-actions bot commented Nov 5, 2024

Conan-Kudo commented Nov 14, 2024

pep8speaks commented Jan 15, 2024 •

edited

Loading

VladimirSlavik Jan 17, 2024 •

edited

Loading