webui: Dont run browser as root #5689
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
adamkankovsky
force-pushed
the
dont-run-browser-as-root-alias
branch
from
5b7b862
to
c628fca
Compare
|
/build-image --live |
|
Images built based on commit c628fca:
Download the images from the bottom of the job status page. |
|
This PR is stale because it has been open 60 days with no activity. |
KKoukiou
force-pushed
the
dont-run-browser-as-root-alias
branch
from
c628fca
to
4cd7d0c
Compare
|
/build-image --live |
|
Images built based on commit 4cd7d0c:
Download the images from the bottom of the job status page. |
KKoukiou
force-pushed
the
dont-run-browser-as-root-alias
branch
from
edc97eb
to
afd2407
Compare
|
/build-image --live |
|
Images built based on commit afd2407:
Download the images from the bottom of the job status page. |
KKoukiou
force-pushed
the
dont-run-browser-as-root-alias
branch
from
afd2407
to
4cd7d0c
Compare
|
/build-image --live |
|
Images built based on commit 4cd7d0c:
Download the images from the bottom of the job status page. |
|
/build-image |
|
Images built based on commit 4cd7d0c:
Download the images from the bottom of the job status page. |
|
/build-image --live |
|
Images built based on commit 4cd7d0c:
Download the images from the bottom of the job status page. |
adamkankovsky
force-pushed
the
dont-run-browser-as-root-alias
branch
4 times, most recently
from
fd737f0
to
8b3279e
Compare
|
/kickstart-tests --testtype smoke |
adamkankovsky
force-pushed
the
dont-run-browser-as-root-alias
branch
from
8b3279e
to
9215999
Compare
|
This PR conflicts with #5946 |
|
But I would like to see both merged soon. |
The titlebar with "Mozilla Firefox" has been fixed but there are some more bits that can be cleaned up. This commit achieves that by: 1. Make sure more of the environment is bubbled through anaconda to the webui launcher. In particular, we need XDG_CURRENT_DESKTOP, but this commit brings it all through, so firefox runs in an environment as close to getting run directly by the live user as possible. 2. Two exceptions are XAUTHORITY and XDG_RUNTIME_DIR which need to remain unset until we can run firefox as a normal user instead of root.
This reverts commit 2e1dff7.
KKoukiou
force-pushed
the
dont-run-browser-as-root-alias
branch
from
9215999
to
637b56d
Compare
|
Lorax PR got merged and release. Reverted the last commit to try if it works. |
|
/kickstart-tests --waive ran already before rebase |
Inspirated by: #5058
This changes for liveOS and boot.iso was tested and works