util: correct errors and suppress stderr for common cases #5959
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elkoniu
reviewed
Oct 24, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
KKoukiou
reviewed
Oct 29, 2024
This was referenced Oct 29, 2024
KKoukiou
requested changes
Nov 1, 2024
jcpunk
force-pushed
the
fix-log-capture
branch
2 times, most recently
from
54be6c7
to
14fb276
Compare
KKoukiou
reviewed
Nov 4, 2024
|
|
||
| if [[ -e /tmp/pre-anaconda-logs/ ]];then | ||
| cp -r /tmp/pre-anaconda-logs ${OUTDIR} | ||
| fi | ||
|
|
||
| tar cfa ${ARCHIVE} ${OUTDIR} | ||
| tar cfa ${ARCHIVE} -C / ./${OUTDIR} |
There was a problem hiding this comment.
Can you explain why we need to change to root? Wasn't it working before?
There was a problem hiding this comment.
With the change to root and addition of ./, tar no longer emits:
tar: Removing leading `/' from member names
14fb276
to
257156e
Compare
KKoukiou
approved these changes
Nov 22, 2024
KKoukiou
force-pushed
the
fix-log-capture
branch
from
257156e
to
be6f1f4
Compare
KKoukiou
approved these changes
Nov 22, 2024
|
/kickstart-tests --testtype logs |
KKoukiou
requested changes
Nov 22, 2024
scripts/log-capture
Outdated
| _to_log ls -l /sys/firmware/efi/efivars | ||
| fi | ||
|
|
||
| if test -e /tmp/*.log; then |
There was a problem hiding this comment.
Sorry I think this does not work:
You need to use: compgen -G ""
There was a problem hiding this comment.
Or something like this:
find /tmp -type f -name '*.log' -exec cp '{}' ${OUTDIR} ';'
KKoukiou
force-pushed
the
fix-log-capture
branch
from
be6f1f4
to
0b2442f
Compare
KKoukiou
requested changes
Nov 22, 2024
KKoukiou
force-pushed
the
fix-log-capture
branch
from
0b2442f
to
7b84430
Compare
| @@ -29,24 +31,26 @@ | |||
| _to_log dmidecode | |||
| _to_log lspci -vvnn | |||
|
|
|||
| for DEV_NAME in $(list-harddrives | cut -d " " -f 1) | |||
| for DEV_NAME in /sys/block/*; do | |||
Check failure
Code scanning / shellcheck
SC1073 Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some errors uncovered in the
log-capturescript as part of the RHEL backport process (#5808).This corrects the errors and should let the tool run in the default case without output to
stderr.