Global (intra-procedural) removal of redundant calls to setVisibility. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 70.11%@@ master #99 diff @@
==========================================
Files 491 491
Lines 95771 95771
Methods 5854 5854
Messages 0 0
Branches 0 0
==========================================
Hits 67151 67151
Misses 28620 28620
Partials 0 0
|
| bool RemoveRedundantCallsToSetVisibility::runOnBasicBlock( | ||
| llvm::BasicBlock& block) { | ||
| int RemoveRedundantCallsToSetVisibility::RemoveRedundantCalls( | ||
| llvm::BasicBlock& block, bool leave_one) { |
There was a problem hiding this comment.
In the (probably) common case where leave_one is false, this could be:
'''
for (llvm::Instruction& instr : block) {
if (isCallToSetVisility(instr)) {
instr.eraseFromParent();
}
}'''
There was a problem hiding this comment.
Unfortunately, eraseFromParent() doesn't seem to work with reverse iterators. But, it might work with forward iterators. Let me see if I can simplify the code using that.
|
The unit tests for the JIT will take a bit longer, because I will need probably need to get some code to get hold of the IR. All the existing unit tests pass. I also want to get rid of all the duplicate error blocks that are currently getting generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.