Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename alert names to follow convention #246

Merged
merged 1 commit into from
Jan 13, 2023
Merged

fix: rename alert names to follow convention #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions bundle/manifests/observability-operator-rules_monitoring.coreos.com_v1_prometheusrule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
groups:
- name: observability-operator.rules
rules:
- alert: Observability Operator controller reconcile errors
- alert: ObservabilityOperatorReconcileErrors
annotations:
description: |
Observability Operator controller - {{ $labels.controller }} fails to reconcile.
Expand All @@ -24,8 +24,7 @@ spec:
for: 15m
labels:
severity: warning
- alert: Observability Operator controller reconcilation takes longer than 10
minutes
- alert: ObservabilityOperatorReconcileLongerThan10Min
annotations:
description: |
Observability Operator controller reconcilation takes longer than 10 minutes for the controller - {{ $labels.controller }}.
Expand All @@ -39,7 +38,7 @@ spec:
for: 10m
labels:
severity: warning
- alert: Observability Operator controller backlog is not being drained
- alert: ObservabilityOperatorBacklogNotDrained
annotations:
description: |
The backlog of Observability Operator controller - {{ $labels.name }} is not getting drained; an indication that reconcile loop may be stuck
Expand Down
6 changes: 3 additions & 3 deletions deploy/monitoring/observability-operator-rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
groups:
- name: observability-operator.rules
rules:
- alert: Observability Operator controller reconcile errors
- alert: ObservabilityOperatorReconcileErrors
annotations:
description: |
Observability Operator controller - {{ $labels.controller }} fails to reconcile.
Expand All @@ -28,7 +28,7 @@ spec:
for: 15m
labels:
severity: warning
- alert: Observability Operator controller reconcilation takes longer than 10 minutes
- alert: ObservabilityOperatorReconcileLongerThan10Min
annotations:
description: |
Observability Operator controller reconcilation takes longer than 10 minutes for the controller - {{ $labels.controller }}.
Expand All @@ -41,7 +41,7 @@ spec:
for: 10m
labels:
severity: warning
- alert: Observability Operator controller backlog is not being drained
- alert: ObservabilityOperatorBacklogNotDrained
annotations:
description: |
The backlog of Observability Operator controller - {{ $labels.name }} is not getting drained; an indication that reconcile loop may be stuck
Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/monitoring/v1alpha1/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ limitations under the License.
*/

// Package v1alpha1 contains API Schema definitions for the rhobs v1alpha1 API group
//+kubebuilder:object:generate=true
//+groupName=monitoring.rhobs
// +kubebuilder:object:generate=true
// +groupName=monitoring.rhobs
package v1alpha1

import (
Expand Down