-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make operator publishable to openshift community-catalog #295
Conversation
@@ -39,6 +39,10 @@ metadata: | |||
} | |||
] | |||
capabilities: Basic Install | |||
categories: Monitoring, Observability | |||
certified: "false" | |||
description: A go based operator to create and manage highly available Prometheus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: A go based operator to create and manage highly available Prometheus | |
description: A Go based operator to create and manage highly available Prometheus |
observability. | ||
description: |2+ | ||
|
||
Observability Operator is an operator created in Go to setup and manage highly available Monitoring Stack using Prometheus and Thanos Querier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observability Operator is an operator created in Go to setup and manage highly available Monitoring Stack using Prometheus and Thanos Querier. | |
Observability Operator is an operator created in Go to setup and manage highly available Prometheus monitoring stack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt its better to have description similar on line 44 and 97 since we didn't mention about Thanos querier earlier. I felt its bit confusing seeing two different descriptions. Leaving up to you which one to choose :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change the description (short) above to
A Go based operator to setup and manage highly available Monitoring Stack
using Prometheus and Thanos Querier.
Both descriptions are different since they appear in different places on UI. The first one has to be concise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use: https://operatorhub.io/preview to preview how OLM renders this.
Observability Operator is an operator created in Go to setup and manage highly available Monitoring Stack using Prometheus and Thanos Querier. | ||
### Supported Features | ||
- Setup multiple Highly Available Prometheus monitoring stack | ||
- Customizable configuration for managing Prometheus deployments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also supports Thanos Querier and Ruler deployment as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd mention Alertmanager and Thanos Querier. It doesn't support Thanos Ruler directly.
description: >+ | ||
|
||
Observability Operator is an operator created in Go to setup and manage | ||
highly available Monitoring Stack using Prometheus and Thanos Querier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same description related comment above
deploy/olm/bases/observability-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
I have converted this to draft to avoid multiple reviews of this PR. |
This PR incorporates all changes required for the operator to be published to the community-catalog (see PR) such as ... - requirement to add CSV.metadata.annotation.containerImage - proper description - links to repo PR: redhat-openshift-ecosystem/community-operators-prod#2712
The changes made here aligns with the 0.0.21 bundle submitted to community catalog - redhat-openshift-ecosystem/community-operators-prod#2712