chore: bump deprecated actions #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpasquier
force-pushed
the
bump-actions
branch
7 times, most recently
from
2ea89a9
to
d652a89
Compare
|
github action review shows a few errors |
|
Should we consider dropping actionlint in favor of a workflow (that also actively blocks PRs) since the current errors don't seem pinpoint the issues they indicate correctly? I believe atleast one of these were carried-over from previous patches that went unnoticed. |
simonpasquier
force-pushed
the
bump-actions
branch
2 times, most recently
from
3702fe3
to
7d5b014
Compare
simonpasquier
commented
Nov 12, 2024
| @@ -6,3 +6,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: reviewdog/action-actionlint@v1 | |||
| with: | |||
| fail_on_error: "true" | |||
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
bump-actions
branch
from
7d5b014
to
c08116c
Compare
slashpai
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.