Cleanup #242
Cleanup #242
Conversation
…eeping some default params, but removing most others
|
This could be hard to validate in the labs-ci-for-ci-cd. I remember when I made big changes to the Jenkinsfile last time, i had to work around some stuff to validate changes to the ci/cd project. If you want when I am back from Hols, would be great to go through some of this stuff together? |
|
@springdo yeah, let me know when you have time. A lot of the whole "using regex" will no longer be needed and a lot of things will be getting chopped out of here. This branch is very much a work in progress at the moment, but I'm modeling off of an existing repo that I've used for a customer and that repo is currently in working order, so I believe getting something working will be fairly straightforward. Additional pieces that need to be solved first, new repos for some of the things that got chopped |
…quirements, update generic docker build location
…now that it's been merge
… update infra-ansible tag, remove TODOs because issues have been opened
|
@springdo it's time to get this merged in. there are a lot of changes here, but re-creating and re-running the Jenkinsfile is very easy. If you want to have a call to talk about it, let me know. |
|
also, @oybed i left some secrets stuff in there (not currently working, i corrupted the encryption on purpose) because i would really like to have an example of using a secret in this. But I'm thinking that since we have the infrastructure repo with the labs-robot secret stuff that I'll probably just do it there or open up a specific private repo here on GH. thoughts? |
|
nvm, deleting the secrets from here. |
|
Hi folks! This PR is two months old as of yesterday. In the spirit of continuous incremental improvement, I'd like to propose that this PR be merged as-is. There are a couple of projects that could use the features in here, and right now the only way to get those features is to work off of @pcarney8's fork instead of an official Labs CI/CD release. Having to choose between fragmentation and missing features is a bummer. I know there's probably some stuff that could use further refinement, but those changes could be done as incremental improvements in the future. Heck, you could even add some improvements before you cut the next release if you wanted. Thanks to everyone for their work building and reviewing this PR! I know you all are juggling several things at once and it can be hard to make time for projects like this. 🚀 😄 🍕 |
|
@pcarney8 lets just move forward. make a tag or something before you merge so its easy to revert |
|
@pcarney8 didn't know you were waiting on me for this one - I never really reviewed it in the first place, just some notes from a quick scan. Anyway - this is a major change, and I think it's probably a waste of time to try to test this before it's merged, so if we have consensus on just merging and fix any issues, I'm fine with that. Sounds like we are, so I'll cut a new release and merge. |
No description provided.