Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎈 FIX - remove the need to build pact & point to new auth template 🎈 #290

Closed
wants to merge 1 commit into from

Conversation

springdo
Copy link
Contributor

@pcarney8 (or whoever else)
This PR should not be merged until we get redhat-cop/openshift-templates#49 merged and off the back of it bump the version of openshift-templates to v1.4.12 as i've pre-emptively bumped the dependency in ci-cd to it

partly towards closing of #286

@springdo
Copy link
Contributor Author

Other PR is in so this should be good to go shortly

@pcarney8
Copy link
Contributor

@springdo I've included your changes in my PR #289 because i needed to update to openshift-templates to v1.4.12 it looks like pact-broker defaults all of your vars (mine is working without them), do you want to keep those in there? if so, i'll add them and we can close this PR

@oybed
Copy link
Contributor

oybed commented Aug 26, 2019

@springdo @pcarney8 Based on above convo, can we close this PR?

@pcarney8 pcarney8 closed this Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants