Fixed missing JDBC driver dependency + .gitignore #23
Conversation
| @@ -13,7 +13,7 @@ create table job_schedule | |||
|
|
|||
| create table student_verification | |||
| ( | |||
| student_pk integer default nextval('student_id_student_pk_seq'::regclass) not null | |||
There was a problem hiding this comment.
this was a hack to get the tables made without errors. I am assuming that the constraint is important.
There was a problem hiding this comment.
Yeah, I am sure of it, but it doesn't seem to work whenever I try to parse it into Postgresql
There was a problem hiding this comment.
That's internally how serial is represented; but serial also creates the sequence. They should probably be switched over to serial to make it easier to use.
There was a problem hiding this comment.
Updated it to serial type in the latest commit.
|
|
||
| # End of https://www.toptal.com/developers/gitignore/api/java,gradle | ||
|
|
||
| # User database + Discord stuff |
There was a problem hiding this comment.
The database.json is a config file containing the connection info to the database - it isn't used as a database.
There was a problem hiding this comment.
Yeah, isn't this file meant to be relative to what you are deploying it to?
Since, the URL to the server and username might be different.
I can commit mine if you want, I just didn't include mine since the repo didn't include one to begin with.
There was a problem hiding this comment.
The filename and comment are just a bit misleading I thought for a second the database had become flatfile.
There was a problem hiding this comment.
Ah fair enough, I just followed the code to see what the bot was looking for in terms of connecting to the PostGresql database.
| arguments= | ||
| auto.sync=false | ||
| build.scans.enabled=false | ||
| connection.gradle.distribution=GRADLE_DISTRIBUTION(LOCAL_INSTALLATION(/home/kurisu/.sdkman/candidates/gradle/current)) |
There was a problem hiding this comment.
What's this file for, should it be committed, and is this supposed to have your home directory in here?
There was a problem hiding this comment.
Argh, this was a hidden file that didn't show up on my IDE, apologies.
build.gradle
Outdated
| @@ -46,4 +38,6 @@ dependencies { | |||
| implementation group: 'io.github.classgraph', name: 'classgraph', version: '4.8.114' | |||
| implementation 'com.zaxxer:HikariCP:5.0.0' | |||
| implementation 'com.fasterxml.jackson.core:jackson-databind:2.12.4' | |||
| implementation 'org.postgresql:postgresql:42.2.0' | |||
There was a problem hiding this comment.
I'm not sure what to do about this, as it made the final JAR a lot bigger.
This should also be updated, or at the least not downgraded.
There was a problem hiding this comment.
Updated to the latest version of Postgresql, as listed here.
|
|
The fixes in this PR contain:
The settings files just are there because of my development setup, feel free to remove them if necessary.