Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The warning that concurrency is not available for reusable workflow is no more relevant. #136

Closed
Ameausoone opened this issue Apr 29, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Ameausoone
Copy link

Concurrency is now supported when we call reusable workflow like :

jobs:
  checks:
    concurrency:
      group: ${{ github.ref }}-${{ github.workflow }}-checks
      cancel-in-progress: true
    uses: ./.github/workflows/unit_tests_and_linters.yaml

So the error .github/workflows/all_in_one.yml:45:5: when a reusable workflow is called with "uses", "concurrency" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "full" [syntax-check]is no more relevant.

The documentation do not mention it yet https://docs.github.com/en/actions/using-workflows/reusing-workflows#supported-keywords-for-jobs-that-call-a-reusable-workflow (But I open a PR github/docs#17469)

@rhysd rhysd added the bug Something isn't working label May 11, 2022
@rhysd
Copy link
Owner

rhysd commented May 11, 2022

Thanks. I'll fix this at next version.

@rhysd
Copy link
Owner

rhysd commented May 11, 2022

I added fix for this issue at issue-136 branch. But let me merge the branch after github/docs#17469 is closed for ensuring that this is an expected behavior.

@rhysd
Copy link
Owner

rhysd commented May 17, 2022

As per this comment, I confirmed this behavior is intended. I'll merge the branch.

@rhysd rhysd closed this as completed in 801a3b3 May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants