Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation of id #182

Closed
amarao opened this issue Jul 24, 2022 · 1 comment
Closed

validation of id #182

amarao opened this issue Jul 24, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@amarao
Copy link

amarao commented Jul 24, 2022

I've just got a reprimand from Github actions whilst actionlint was totally OK:

The identifier 'Set production tag (semantic)' is invalid. IDs may only contain alphanumeric characters, '_', and '-'. IDs must start with a letter or '_' and and must be less than 100 characters.

I believe Actionlint may validate steps ID to match Github requirements.

Example of a bad workflow:

"on":
  push:

jobs:
  foo:
    steps:
      - id: Set production tag (semantic)
        run: echo hello

Sorry for the issue instead of a PR, Go is not my strongest.

@rhysd rhysd added the enhancement New feature or request label Aug 17, 2022
@rhysd
Copy link
Owner

rhysd commented Aug 17, 2022

Thanks for your suggestion. It should be detected by actionlint.

@rhysd rhysd closed this as completed in 0cca1b5 Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants