Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a reusable workflow is called with "uses", "strategy" is not available. #197

Closed
TessaPhillips opened this issue Aug 23, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@TessaPhillips
Copy link

I'm getting the following action lint error when I am using a reusable workflow with a matrix strategy.

.github/workflows/lint-and-format.yaml:12:5: when a reusable workflow is called with "uses", "strategy" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "python-pr-lint" [syntax-check]

As per the documentation, this is valid, and the workflow actually runs fine. Can action lint please be updated to match the documentation? - https://docs.github.com/en/actions/using-workflows/reusing-workflows#example-matrix-strategy-with-a-reusable-workflow

@seemethere
Copy link

Submitted #199 to resolve

@rhysd
Copy link
Owner

rhysd commented Aug 24, 2022

This was made valid very recently (just 2 days ago). So actionlint is not following the update yet.

https://github.blog/changelog/2022-08-22-github-actions-improvements-to-reusable-workflows-2/

Reusable workflows can now be called from a matrix and other reusable workflows.

@rhysd rhysd added the bug Something isn't working label Aug 24, 2022
@rhysd rhysd closed this as completed in 4da232c Aug 24, 2022
@rhysd
Copy link
Owner

rhysd commented Aug 28, 2022

This was fixed in v1.6.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants