Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ignore list in actionlint.yaml #217

Closed
zvif-orca opened this issue Sep 20, 2022 · 7 comments
Closed

support ignore list in actionlint.yaml #217

zvif-orca opened this issue Sep 20, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@zvif-orca
Copy link

zvif-orca commented Sep 20, 2022

Required Functionality
actionlint may require some customization when deployed into existing project
Adding the ignore errors manually to a long command is not user friendly

Proposed Solution
Add support for ignore list in actionlint.yaml to keep things neat

@rhysd
Copy link
Owner

rhysd commented Sep 20, 2022

Question: Why -ignore is not sufficient for your use case?

@zvif-orca
Copy link
Author

zvif-orca commented Sep 20, 2022

If you mean to the cli argument - it is sufficient for my case
It is just that I prefer to maintain the ignore list of in actionlint.yaml instead of maintaining a long command
I followed the docs and from what I understand it is currently not supported, if this is the case - it would be nice to have

@rhysd
Copy link
Owner

rhysd commented Sep 27, 2022

I'm trying to keep config file as small as possible so let me consider whether it should be configured in the file.

@rhysd rhysd added the enhancement New feature or request label Sep 27, 2022
@ryanking
Copy link

I would love to vote for stuff like this in the config file, as well. The reason is that I would like to run the tool in at least 3 different contexts - in my editor, at the command line and in CI. Having a single source of truth for the configuration options across those runs will make keeping them in sync much easier.

@u-yas
Copy link

u-yas commented Aug 22, 2023

As a current workaround, it's convenient to run it via a wrapper bash script.

#!/bin/bash
# ./scripts/actionlint

#  https://www.gnu.org/software/bash/manual/bash.html#index-_0040
actionlint -ignore 'some 1' -ignore 'some 2' "$@" 
chmod +x scripts/actionlint
./scripts/actionlint -no-color

@rubarcelk
Copy link

I have similiar requirement. Instead of maintaining separate Bash scripts to bypass these linting errors, I would prefer to configure my actionlint.yml file to explicitly ignore these specific errors. This approach will streamline my workflow by reducing the need for additional scripting and focusing on the essential aspects of my GitHub Actions.

@pgreze
Copy link

pgreze commented Sep 13, 2024

+1 on this feature request. By having all parameters (but especially ignore in this case) in the actionlint.yml, this would allow to run the CLI locally and on CI with the same configuration without having to create a wrapper bash script as advised in a previous comment.

@rhysd rhysd closed this as completed in 0c0a521 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants