Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warning for workflow_dispatch input type number. #319

Closed
inahga opened this issue Jul 5, 2023 · 1 comment
Closed

Incorrect warning for workflow_dispatch input type number. #319

inahga opened this issue Jul 5, 2023 · 1 comment

Comments

@inahga
Copy link

inahga commented Jul 5, 2023

Example workflow:

name: test

on:
  workflow_dispatch:
    inputs:
      test:
        type: number
        default: "0"

jobs:
  job1:
    runs-on: ubuntu-latest
    steps:
      - run: echo hello world

I receive this lint:

test.yml:7:15: input type of workflow_dispatch event must be one of "string", "boolean", "choice", "environment" but got "number" [syntax-check]
  |
7 |         type: number
  |               ^~~~~~

Actionlint version:

🐧 actionlint --version
v1.6.25
installed by building from source
built with go1.20.4 compiler for linux/amd64

This is not correct, number is valid for the input type. See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_dispatchinputsinput_idtype. Github also accepts the input just fine.

(more than happy to work on this myself, just filing an issue so I don't forget!)

@inahga
Copy link
Author

inahga commented Jul 5, 2023

Whoops, dupe of #316. I just need to wait for the next release :)

@inahga inahga closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant