Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-pages deploy failure #1

Closed
dalance opened this issue Nov 12, 2019 · 8 comments
Closed

gh-pages deploy failure #1

dalance opened this issue Nov 12, 2019 · 8 comments

Comments

@dalance
Copy link

dalance commented Nov 12, 2019

In README and example, GITHUB_TOKEN is used to push.
Currently this causes failure of pages deploy.

https://github.saobby.my.eu.orgmunity/t5/GitHub-Actions/Github-action-not-triggering-gh-pages-upon-push/td-p/26869

Alternatively personal access token can be used.

peaceiris/actions-gh-pages may be usable, but I didn't confirm.

@rhysd
Copy link
Member

rhysd commented Nov 13, 2019

Hmm, but example workflows in this repository are able to push gh-pages branch to remote.

I think the problem GITHUB_TOKEN which cannot push to remote happens only within action. Environment which runs action is different from one which runs workflow. Workflow seems to be able to push branch to remote.

github-action-benchmark does not push to remote by itself. Pushing to remote is done by user in workflow. So I think the action can avoid the issue you reported.

@dalance
Copy link
Author

dalance commented Nov 13, 2019

Sorry. push is success, but pages deploy is failed.
In my project, "Settings" -> "GitHub Pages" shows "build failed" after pushing by GITHUB_TOKEN.

@dalance dalance changed the title gh-pages push failure gh-pages deploy failure Nov 13, 2019
@dalance
Copy link
Author

dalance commented Nov 13, 2019

For example, https://rhysd.github.io/github-action-benchmark/dev/bench/ shows the latest commit is b652625.
But the latest build https://github.com/rhysd/github-action-benchmark/runs/299122357 is success.
So the latest commit should be 505be0a.
The deploy of pages seems to be continuously failed since b652625.

@rhysd
Copy link
Member

rhysd commented Nov 13, 2019

Ahh, I understood. For some development reason, I pushed gh-pages from my local machine. The commit at that time deployed gh-pages successfully. But other commits pushed by action fail.

Thank you for the point. As of now, we need to use personal token. I'll update this repository and include note about this in README.

@rhysd
Copy link
Member

rhysd commented Nov 13, 2019

I confirmed using personal access token with no scope could build gh-pages.

スクリーンショット 2019-11-13 15 27 46

@rhysd
Copy link
Member

rhysd commented Nov 13, 2019

I updated example workflows to use personal access token. And added an extra step to register a personal access token in basic usage section of README.md. I believe they are sufficient to close this issue. Thank you for reporting this.

@dalance
Copy link
Author

dalance commented Nov 13, 2019

Thank you for your quick response.

@WizardOfMenlo
Copy link

Hi there. Just wanted to point out that as of now I tested and deploying GitHub pages with the GITHUB_TOKEN seems to be working properly, so the extra steps should not be needed anymore.

mkungla pushed a commit to mkungla/github-action-benchmark that referenced this issue Dec 15, 2020
ktrz added a commit that referenced this issue Oct 12, 2021
Remove references to payload as much as possible
wwerkk added a commit to wwerkk/github-action-benchmark that referenced this issue Apr 30, 2024
remove calls to addIndexHtmlIfNeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants