fix: batch submission now does not require user to write to script first #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AroneyS
reviewed
Apr 8, 2024
AroneyS
reviewed
Apr 8, 2024
|
Can you add a batch test to test_integration? Could just use the short and the long-read recovery. |
|
The new test runs for me until |
|
That is likely because you've installed a new version of smafa using cargo install, and that is on the PATH first. So an issue specific to you. Neither smafa nor singlem has yet been released to handle v2 smafa databases yet - this will come as a concerted thing in singlem 0.18.0, which I'm working on. |
AroneyS
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.