Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circlator yaml #40

Merged
merged 1 commit into from
May 4, 2022
Merged

Update circlator yaml #40

merged 1 commit into from
May 4, 2022

Conversation

sternp
Copy link
Collaborator

@sternp sternp commented May 4, 2022

Spades 3.7.1 is recommended as it gives better results

Spades 3.7.1 is recommended as it gives better results
@rhysnewell
Copy link
Owner

Happy to update this, but do you have a source for this? What do they mean by better? Just want to make sure before regressing so many updates

@sternp
Copy link
Collaborator Author

sternp commented May 4, 2022

You are greeted by the following message when circlator launches:

WARNING: SPAdes version 3.9.0 is being used. It will work, but better results are usually obtained from Circlator using SPAdes version 3.7.1. Although 3.7.1 is not the latest version, we recommend it for Circlator.

@rhysnewell rhysnewell merged commit 4dba851 into rhysnewell:master May 4, 2022
@rhysnewell
Copy link
Owner

Lol, true. I still wonder what they mean by better, happy to merge this.

@sternp
Copy link
Collaborator Author

sternp commented May 4, 2022

Okay - so 3.7.1 isn't available in conda.

Also, apparently (sanger-pathogens/circlator#72) the 'improved' performance might be a result of misassemblies.

For these two reasons can you revert this back to spades 3.9.0. Sorry for this!

@rhysnewell
Copy link
Owner

Yeah, the misassemblies was what I was thinking... A lot of the time older versions of assemblers seem to perform better than newer versions, but it is just the result of misassemblies creating larger contigs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants