Skip to content

init #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smiller171 merged 12 commits into from
Jun 1, 2020
Merged

init #1

smiller171 merged 12 commits into from
Jun 1, 2020

Conversation

@smiller171
Copy link
Contributor

@smiller171 smiller171 commented May 27, 2020

No description provided.

@smiller171 smiller171 requested a review from cdaniluk May 27, 2020 18:21
@smiller171 smiller171 requested a review from sblack4 May 28, 2020 17:27
sblack4
sblack4 requested changes May 28, 2020
View reviewed changes
Copy link
Contributor

@sblack4 sblack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks way easier than packer. One small date change though

@smiller171 @sblack4
Update LICENSE
85411ff 
Co-authored-by: Steven B <genseb7@gmail.com>
sblack4
sblack4 approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@sblack4 sblack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

cdaniluk
cdaniluk requested changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@cdaniluk cdaniluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proforma comment about the output name and lazyCamelCase from the other PRs. Whatever we decide we should do it consistently across all 3 of these modules.

@sblack4
Copy link
Contributor

sblack4 commented Jun 1, 2020

proforma comment about the output name and lazyCamelCase from the other PRs. Whatever we decide we should do it consistently across all 3 of these modules.

Lettuce mark this decision in the annals of engineering standards, rhythmictech/terraform-aws-imagebuilder-recipe#1 (comment)

sblack4
sblack4 reviewed Jun 1, 2020
View reviewed changes
@smiller171 smiller171 requested a review from cdaniluk June 1, 2020 13:53
@smiller171
Copy link
Contributor Author

smiller171 commented Jun 1, 2020

proforma comment about the output name and lazyCamelCase from the other PRs. Whatever we decide we should do it consistently across all 3 of these modules.

Lettuce mark this decision in the annals of engineering standards, rhythmictech/terraform-aws-imagebuilder-recipe#1 (comment)

unmark your PR as a draft so we can review it

@smiller171 smiller171 merged commit 2f9e5ca into master Jun 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the init branch June 1, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sblack4 sblack4 sblack4 approved these changes

@cdaniluk cdaniluk cdaniluk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smiller171 @sblack4 @cdaniluk