-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CalDateTime equality operators handle null-values incorrectly. #372
Comments
Looks reasonable. I’ll merge a stylistically tweaked version of this this week. |
Available in nuget version 4.1.5: |
rianjs
pushed a commit
that referenced
this issue
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CalDateTime.operator ==
andCalDateTime.operator !=
fail when comparing against null. This implies, that natural expressions like((x == null) || (x <= y))
fail. This certainly violates the intended contract for == and !=. It probably should be implemented similar to:Other comparison operators should probably handle null values gracefully too. Here is, how Nullable<T> does it:
The text was updated successfully, but these errors were encountered: