Equals on the CalendarEvent should only be true if summary and description match #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuehlma
force-pushed
the
equals_with_different_summary
branch
from
a118e7c
to
a3260a4
Compare
rianjs
approved these changes
Sep 19, 2017
|
Oh, and you should never change That's true in all of the code you write. |
rianjs
pushed a commit
that referenced
this pull request
Sep 19, 2017
|
ok, will update both versions of the library in the future. for the GetHashCode: I made the Equals more strict. GetHashCode needs to be the same if Equals true. If Equals is false, GetHashCode may still be the same. This should still be the case. But yes, the HashCode could be improved by also adding the fields there. Oh and thanks for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.