Catch case where recurring item has no Start #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rianjs
reviewed
Oct 17, 2017
There was a problem hiding this comment.
Yeah, it looks like the only required property in VTODOs is the DTSTAMP:
https://tools.ietf.org/html/rfc5545#section-3.6.2
Can you make the same change in the .NET 2.x version as well in the v2 folder? Should be in the same place.
rbuehlma
force-pushed
the
fix_npe_if_no_start
branch
from
2a2c2cb
to
e185a49
Compare
|
Sorry, missed the 2.x version again :-S done now. |
rianjs
reviewed
Oct 17, 2017
There was a problem hiding this comment.
Cool. Two last things:
- Can you edit the nuspec files in both the
v2andnet-coreversions and bump the patch version by 1? - Then add a short blurb to
release-notes.mdexplaining the change with the associated major.minor.patch version. (You'll see what I mean when you open the file.) Something like "DTSTARTis not required forVTODOcomponents." would be sufficient.
Then I'll merge and publish new versions to nuget.
|
Done as well. |
rbuehlma
force-pushed
the
fix_npe_if_no_start
branch
from
e185a49
to
6aebdfb
Compare
rianjs
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case, the object without a Start was a TODO. The backend is Zimbra. I'm not sure if it is a Bug in Zimbra or if it is actually a valid item but the fix is simple in the library.