Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining data and basemap at the commune scale #38

Closed
aschoenauer-sebag opened this issue Mar 12, 2019 · 4 comments · Fixed by #42
Closed

Joining data and basemap at the commune scale #38

aschoenauer-sebag opened this issue Mar 12, 2019 · 4 comments · Fixed by #42

Comments

@aschoenauer-sebag
Copy link

Hi,

We are trying to plot data at the commune level. We're easily loading the template from http://magrit.cnrs.fr as well as our data ; however when attempting to join COMMUNES and our data using INSEE codes MAGRIT displays "Loading results" and never finishes.

Thanks for your help,
Alice

@mthh
Copy link
Member

mthh commented Mar 12, 2019

Thanks for the report !

Indeed, it's a bug in Magrit. When the number of entities is particularly high, the join is not done in the main thread but in a webworker (in which the error is encountered...).

I pushed a fix but CI is causing us some troubles right now and I may have to merge some others stuff before I can bring this fix back to the master branch (so I will close this issue once merged on master and deployed on magrit.cnrs.fr).

@aschoenauer-sebag
Copy link
Author

OK, thanks for your quick reply. Looking forward to the merge on master (any idea if this will be sooner, or rather later? :).

Thanks,
Alice

@mthh
Copy link
Member

mthh commented Mar 14, 2019

Normally during the next week ...!

We do not share offices with @rCarto anymore and we have a few things to work on before publishing a new version :)

@aschoenauer-sebag
Copy link
Author

Great, thanks for keeping us updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants