-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: pem certificate support #19
Conversation
Adds CERTIFICATE tag for pem files. RSA tests were extended with certificates. Self-signed certificates were generated: # openssl req -new -key private.pem -out certificate.csr # openssl x509 -req -days 358000 -in certificate.csr -signkey private.pem -out certificate.crt certificate.crt files may be checked at https://www.sslchecker.com/certdecoder
Thanks this looks good to me, with just one comment about whether it's really valid to differentiate between I'll also link to this issue: Keats/jsonwebtoken#259 and this PR Keats/jsonwebtoken#274 with equivalent changes that help add relevant context here. |
I there anything you want me to change in this PR? |
Is there a practical difference between As I understand it they test the same thing (it doesn't really matter that the input keys to create the certificates were in pkcs1 vs pkcs8?). If that's the case then we can remove one of the tests and just add a single |
I removed the test, but left the name |
Can I ask you to make a release when the PR is merged? |
Thanks this looks good to me. Yeah, I'm travelling at the moment but will try to spin a release after merging this. I'd like to add a CHANGELOG and double check that it's only a semver patch bump. Since it looks like the libs team came to a good conclusion here rust-lang/rust#103763 (comment) then I'm also inclined to revert back to simply using Line 60 in a0969ae
|
Adds CERTIFICATE tag for pem files.
RSA tests were extended with certificates.
Self-signed certificates were generated:
certificate.crt files may be checked at https://www.sslchecker.com/certdecoder