remaining comments

ribbon-finance · Jun 30, 2023 · 29a59c9 · 29a59c9
1 parent 504e35f
commit 29a59c9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/contracts/libraries/VaultLifecycleTreasury.sol b/contracts/libraries/VaultLifecycleTreasury.sol
@@ -742,6 +742,7 @@ library VaultLifecycleTreasury {
         );
         require(bytes(_initParams._tokenName).length > 0, "!_tokenName");
         require(bytes(_initParams._tokenSymbol).length > 0, "!_tokenSymbol");
+        require((_initParams._period > 0), "!_period");
         require(
             _initParams._optionsPremiumPricer != address(0),
             "!_optionsPremiumPricer"

diff --git a/contracts/vaults/TreasuryVault/RibbonTreasuryVault.sol b/contracts/vaults/TreasuryVault/RibbonTreasuryVault.sol
@@ -443,10 +443,8 @@ contract RibbonTreasuryVault is
 
         for (uint256 i = 0; i < arrayLength - 1; i++) {
             if (excludeDepositor == array[i]) {
-                (array[i], array[arrayLength - 1]) = (
-                    array[arrayLength - 1],
-                    array[i]
-                );
+                array[i] = array[arrayLength - 1];
+                break;
             }
         }
         array.pop();