does not lint anymore

[despairblue]

Happens when updating to version 2.0.0 or later

1.2.0 still lints.

[ricardofbarros]

Did you update AtomLinter as well?

[despairblue]

atom linter 1.2.4

[despairblue]

It's probably because of the two new options, which I have both disabled.

[ricardofbarros]

If so you still have the style option fallback,

what can happen is if you have checkStyleDevDependencies option ticked it won't lint the file if the there isn't specified the style of the project on package.json devDependencies

[despairblue]

I haven't ticked checkStyleDevDependencies nor honorStyleSettings and my chosen style is standard.

My config looks like

  "linter-js-standard": {}

Settings:

package.json:

  "devDependencies": {
    "faucet": "0.0.1",
    "groc": "0.6.3",
    "istanbul": "0.3.0",
    "jasmine": "2.2.1",
    "node-inspector": "0.10.1",
    "nodemon": "1.3.2",
    "standard": "*",
    "supertest": "0.13.0",
    "tape": "^4.0.0"
  }

[despairblue]

This is probably as puzzling to you as it is to me 😕

[ricardofbarros]

Hmm awkward, let me try to replicate.

[despairblue]

Ah I get a rejected promise:

Error: Notification must be created with string message: undefined
  at Notification.module.exports.Notification.validate (/usr/share/atom/resources/app.asar/src/notification.js:25:15)
  at new Notification (/usr/share/atom/resources/app.asar/src/notification.js:20:12)
  at NotificationManager.module.exports.NotificationManager.addError (/usr/share/atom/resources/app.asar/src/notification-manager.js:41:35)
  at /home/despairblue/.atom/packages/linter/lib/editor-linter.coffee:78:30

[despairblue]

The rejection does not happen with other linters.

[despairblue]

this line ends up being called with this string as error

"standard: Use JavaScript Standard Style (https://github.com/feross/standard)
"

Thus error.message is undefined.

[ricardofbarros]

What the hell?? 😧

[ricardofbarros]

Could you insert this

console.log(occurences)

on this line and give me the output

[despairblue]

Get's never called. :(

[despairblue]

Which makes sense, since this promise is rejected, so then is executed.

[despairblue]

Ok standard outputs standard: Use JavaScript Standard Style (https://github.com/feross/standard) to stderr and all subsequent errors to stdout. The problem is this part of atom-linter.

If you pass no options it assumes 'stdout' and will reject if there is anything in stderr (which there is: standard: Use JavaScript Standard Style (https://github.com/feross/standard)). If you pass stderr as option (or anything but stdout or null/undefined for that matter) it will resolve with stderr (standard: Use JavaScript Standard Style (https://github.com/feross/standard)).

This is a pretty fucked up situation, there is simply no way to reach line 30 😕

steelbrain/atom-linter@40d9f0e is the offending commit.

[despairblue]

As a precaution I'd always use fixed versions in the package.json.

[ricardofbarros]

Couldn't we redirect stderr to stdout?

[ricardofbarros]

Try the following fix in this line to see if it works for you:

args.push('2>&1')

[ricardofbarros]

In the upcoming release that promise will have a .catch

[despairblue]

This does nothing, I doubt it's passed to a shell as such, the process is probably started with a syscall, which would mean the argument is just passed to through to standard.

[despairblue]

I made a PR to fix this for now.

[despairblue]

btw, all this makes me think of

[ricardofbarros]

Ehehe 😄

Thank you @despairblue

[ricardofbarros]

Published a patch, could you see if that works for you?

[despairblue]

👍 works. @steelbrain is also implementing an option to disable the rejection when the linter writes to stderr.

I'll issue another PR when it's published.

[ricardofbarros]

Cool! Many thanks 👍

[ricardofbarros]

atom-linter released 3.0.0 with it came the new option you were talking about throwOnStdErr, I released the 2.2.0 to follow with these changes.