fix checkStyleSettings when path not found #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkStyleSettings should never return undefined
|
Hey @tjmehta, thanks for the PR I will review shortly and get back at you. Thanks |
|
Let me know if you have any questions :) |
jscissr
reviewed
Jun 14, 2017
| @@ -39,7 +39,7 @@ function checkStyleSettings (filePath) { | |||
| projectPath = projectPaths.find((p) => absoluteActivePanePath.indexOf(fs.realpathSync(p)) >= 0) | |||
| } catch (e) { | |||
| console.error('Could not get project path', e) | |||
| return | |||
| return {} | |||
There was a problem hiding this comment.
You could also write return settings like all the other return statements, because settings is an empty object anyways
|
I have fixed this in 3c9ad13. Instead of simply returning early, I have decided to use the path returned by Nevertheless, thank you, @tjmehta and @jscissr, for pointing us to the source of the error 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open files in atom can be moved or deleted. When nonexistant files are listed,
checkStyleSettingsto returnsundefinedwhich causes #168. For now, I returned an empty object even whencheckStyleSettingsswallows any file read error.