Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19: Add happiness as a third style option #20

Merged
merged 1 commit into from
Jul 8, 2015

Conversation

developit
Copy link
Contributor

I like this module, but I use tabs and semicolons when writing ES6 - happiness is a fork of standard/semi-standard that enforces those rules out-of-the-box, so I figured it would make a good addition to this linter.

@ricardofbarros Apologies if I've messed anything up here - this is actually the first time I've tried submitting a PR to a CoffeeScript project :)

Edit: happiness issue: JedWatson/happiness#3

@ricardofbarros
Copy link
Owner

I will review this shortly, but at first glance everything seems fine, I need to start thinking on making tests.

@developit
Copy link
Contributor Author

Yup, I was just going to ask if you had a way you normally tested this stuff. I've never hacked on an Atom package before, so I'm not sure if it's like npm where I can just swap the files locally or use link/link-local.

@ricardofbarros
Copy link
Owner

You can do the following:

  • apm link linter-js-standard/ --dev
  • atom --dev

I need to read more about the specs and how Atom does the unit tests, but that is how I test local stuff.

@developit
Copy link
Contributor Author

I was able to confirm it works. On a project with tabs in-use, switching the engine from standard to happiness brought my error count from ~350 to ~90. Now I just need to fix up my codebase ;)

@dcousens
Copy link

dcousens commented Jul 8, 2015

LGTM thanks @developit :)

@ricardofbarros ricardofbarros merged commit 6b86e1e into ricardofbarros:master Jul 8, 2015
@ricardofbarros
Copy link
Owner

Merged :) going to release a minor version and edit the readme.

Thank you @developit

@developit developit deleted the feature/happiness branch July 8, 2015 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants