Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated happiness #86

Closed

Conversation

wesleytodd
Copy link

We recently updated happiness to follow more closely with standard. So pinning a version shouldn't be as important, so I changed it to the most recent major version range. I dont have much experience with atom packages , so I don't know how to test it, but the api between standard@5.2.1 should be the same as happiness@5.5.0. If you have instructions on how I can run this branch on my atom install I would love to try to make sure it is all working. Unless you are confident it is alright. Thanks!

@wesleytodd
Copy link
Author

Ping :)

@ricardofbarros
Copy link
Owner

Hey @wesleytodd sorry for the late reply, I'm currently undergoing a refactor of this package for the next major version to in way fix this type of problems, people will be able in the future to use a specific version of standard, semistandard, happiness, etc.. So that's why I'm not merging this, but thanks for the heads up, when I will release I will update the default versions and I surely will update thehappiness`default version to 5.5.0. Once again sorry for the late reply.

@wesleytodd
Copy link
Author

Sounds awesome! Thanks for the update.

@ricardofbarros
Copy link
Owner

Hello @wesleytodd. Seems like a PR from @devtristan came first to address this issue.

So as now this is fixed on the latest release 3.3.0.

Thanks. But I will still update this package in the meantime with some new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants