Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): remove vanilla-extract workaround #334

Merged
merged 6 commits into from
Aug 21, 2022

Conversation

riccardoperra
Copy link
Owner

Finally fixes vanilla-extract with solid-js and pnpm monorepo

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2022

⚠️ No Changeset found

Latest commit: a30c74c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riccardoperra riccardoperra temporarily deployed to Preview August 21, 2022 13:29 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2022

Deploy preview for codeimage ready!

✅ Preview
https://codeimage-bzv7yqtpz-riccardoperra.vercel.app
https://codeimage-pr-334.vercel.app

Built with commit d552c63.
This pull request is being automatically deployed with vercel-action

@riccardoperra riccardoperra temporarily deployed to Preview August 21, 2022 13:37 Inactive
fix(app): remove vanilla-extract workaround
@riccardoperra riccardoperra merged commit fd6ae6f into next Aug 21, 2022
@riccardoperra riccardoperra deleted the fix/vanilla-extract-solidjs branch August 22, 2022 07:26
riccardoperra added a commit that referenced this pull request Sep 4, 2022
* fix(app): fix vanilla extract types
* fix(app): remove vanilla-extract workaround
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant