Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pagination cleanup #359

Merged
merged 4 commits into from
Sep 17, 2022
Merged

fix: pagination cleanup #359

merged 4 commits into from
Sep 17, 2022

Conversation

riccardoperra
Copy link
Owner

relates to #325

@codesandbox
Copy link

codesandbox bot commented Sep 17, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: c294e94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riccardoperra riccardoperra temporarily deployed to Preview September 17, 2022 15:09 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2022 •
edited
Loading

Deploy preview for codeimage ready!

✅ Preview
https://codeimage-b0uv6fz92-riccardoperra.vercel.app
https://codeimage-pr-359.vercel.app

Built with commit c294e94.
This pull request is being automatically deployed with vercel-action

@riccardoperra riccardoperra temporarily deployed to Preview September 17, 2022 15:13 Inactive
hackpirodev
hackpirodev reviewed Sep 17, 2022
View reviewed changes
packages/ui/src/lib/primitives/Pagination/Pagination.css.ts
Comment on lines +1 to +7
import {style} from '@vanilla-extract/css';
import {themeVars} from '../../theme';

export const pagination = style({
display: 'flex',
gap: themeVars.spacing[2],
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riccardoperra perchè usare custom css quando abbiamo il box che settando le giuste properties otteniamo le stesse cose?

@riccardoperra riccardoperra temporarily deployed to Preview September 17, 2022 15:19 Inactive
@riccardoperra riccardoperra temporarily deployed to Preview September 17, 2022 15:31 Inactive
@riccardoperra riccardoperra merged commit 0511660 into next Sep 17, 2022
@riccardoperra riccardoperra deleted the fix/pagination-cleanup branch September 17, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackpirodev hackpirodev hackpirodev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riccardoperra @hackpirodev