Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement local system font picker for theme builder #576

Merged
merged 8 commits into from
Nov 30, 2023

Conversation

riccardoperra
Copy link
Owner

@riccardoperra riccardoperra commented Nov 25, 2023

This update introduces the Local Font Access API to the theme builder. This allows to users to use their system fonts automatically

This update introduces a local system font picker
Copy link

codesandbox bot commented Nov 25, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Nov 25, 2023

⚠️ No Changeset found

Latest commit: 78ae2cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 25, 2023

Deploy preview for codeimage-website-dev ready!

✅ Preview
https://codeimage-website-8bz0odyo7-riccardoperra.vercel.app
https://codeimage-website-pr-576.vercel.app

Built with commit 78ae2cf.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

github-actions bot commented Nov 26, 2023

Deploy preview for codeimage ready!

✅ Preview
https://codeimage-1fpn9mdf7-riccardoperra.vercel.app
https://codeimage-app-pr-576.vercel.app

Built with commit 78ae2cf.
This pull request is being automatically deployed with vercel-action

@riccardoperra
Copy link
Owner Author

Must investigate about Listbox item not rendering correctly when appyling filter

image

image

Copy link
Collaborator

@hackpirodev hackpirodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @riccardoperra, we should merge this before then my pr, because there could be some merge conflict (not sure about that)

Copy link
Contributor

Deploy preview for codeimage-highlight-dev ready!

✅ Preview
https://codeimage-highlight-98xhvrdo3-riccardoperra.vercel.app
https://codeimage-highlight-pr-576.vercel.app

Built with commit 78ae2cf.
This pull request is being automatically deployed with vercel-action

@riccardoperra riccardoperra merged commit d9fd2eb into main Nov 30, 2023
11 of 12 checks passed
@riccardoperra riccardoperra deleted the feat/font-experimental-system-api branch November 30, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🚀 - Add Local Font Access API
2 participants