Fix issue magento#14112

- set null OptionId - set null all ProductLink to prevent overwrite of duplicated bundle product in table `catalog_product_bundle_selection`
riccardougolini · Jun 10, 2018 · 2a67fd7 · 2a67fd7
1 parent c62d922
commit 2a67fd7
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 7 deletions.
diff --git a/app/code/Magento/Bundle/Model/Product/CopyConstructor/Bundle.php b/app/code/Magento/Bundle/Model/Product/CopyConstructor/Bundle.php
@@ -24,10 +24,22 @@ public function build(Product $product, Product $duplicate)
             return;
         }
 
+        /** @var \Magento\Bundle\Api\Data\OptionInterface[]|null $bundleOptions */
         $bundleOptions = $product->getExtensionAttributes()->getBundleProductOptions() ?: [];
+
+        /** @var \Magento\Bundle\Api\Data\OptionInterface[]|null $duplicatedBundleOptions */
         $duplicatedBundleOptions = [];
+
         foreach ($bundleOptions as $key => $bundleOption) {
             $duplicatedBundleOptions[$key] = clone $bundleOption;
+            $duplicatedBundleOptions[$key]->setOptionId(null);
+            /** @var \Magento\Bundle\Api\Data\LinkInterface[]|null $bundleSelections */
+            $bundleSelections = $duplicatedBundleOptions[$key]->getProductLinks();
+
+            /** @var \Magento\Bundle\Api\Data\LinkInterface $bundleSelection */
+            foreach($bundleSelections as $bundleSelection){
+                $bundleSelection->setSelectionId(null);
+            }
         }
         $duplicate->getExtensionAttributes()->setBundleProductOptions($duplicatedBundleOptions);
     }

diff --git a/app/code/Magento/Bundle/Test/Unit/Model/Product/CopyConstructor/BundleTest.php b/app/code/Magento/Bundle/Test/Unit/Model/Product/CopyConstructor/BundleTest.php
@@ -8,6 +8,7 @@
 use Magento\Bundle\Api\Data\BundleOptionInterface;
 use Magento\Bundle\Model\Product\CopyConstructor\Bundle;
 use Magento\Catalog\Api\Data\ProductExtensionInterface;
+use Magento\Catalog\Api\Data\ProductLinkInterface;
 use Magento\Catalog\Model\Product;
 use Magento\Catalog\Model\Product\Type;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
@@ -61,12 +62,8 @@ public function testBuildPositive()
             ->willReturn($extensionAttributesProduct);
 
         $bundleOptions = [
-            $this->getMockBuilder(BundleOptionInterface::class)
-                ->disableOriginalConstructor()
-                ->getMockForAbstractClass(),
-            $this->getMockBuilder(BundleOptionInterface::class)
-                ->disableOriginalConstructor()
-                ->getMockForAbstractClass()
+            $this->createBundleOption(),
+            $this->createBundleOption()
         ];
         $extensionAttributesProduct->expects($this->once())
             ->method('getBundleProductOptions')
@@ -86,7 +83,6 @@ public function testBuildPositive()
         $extensionAttributesDuplicate->expects($this->once())
             ->method('setBundleProductOptions')
             ->withConsecutive([$bundleOptions]);
-
         $this->model->build($product, $duplicate);
     }
 
@@ -131,4 +127,32 @@ public function testBuildWithoutOptions()
 
         $this->model->build($product, $duplicate);
     }
+
+    /**
+     * @return BundleOptionInterface|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private function createBundleOption()
+    {
+        /** @var \PHPUnit_Framework_MockObject_MockObject|BundleOptionInterface $bundleOptionMock */
+        $bundleOptionMock = $this->getMockBuilder(BundleOptionInterface::class)
+            ->setMethods(['getProductLinks'])
+            ->disableOriginalConstructor()
+            ->getMockForAbstractClass();
+
+        /** @var \PHPUnit_Framework_MockObject_MockObject|ProductLinkInterface $productLinkMock */
+        $productLinkMock = $this->getMockBuilder(ProductLinkInterface::class)
+            ->setMethods(['setSelectionId'])
+            ->disableOriginalConstructor()
+            ->getMockForAbstractClass();
+
+        $productLinkMock->expects($this->once())
+            ->method('setSelectionId')
+            ->with(null);
+
+        $bundleOptionMock->expects($this->once())
+            ->method('getProductLinks')
+            ->willReturn([$productLinkMock]);
+
+        return $bundleOptionMock;
+    }
 }