Throw error for insufficient initial heating #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking this on! This looks good to me. Would you mind including a test for this as well? |
|
Right, good point. I've added a test to make sure it returns a runtime error. |
wtbarnes
reviewed
Jul 12, 2024
wtbarnes
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
Throws an error for small initial heating values, such that it is approaching the range where ebtel++ would fail to produce equilibrium conditions. The threshold is slightly higher than the actual point of failure, but the initial temperatures produced right at the threshold are on the order of a few x$10^{4}$ K, which is perhaps a questionable initial condition for ebtel++ anyway.